Graph class formation #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athityakumar
requested changes
Feb 27, 2018
There was a problem hiding this comment.
Doesn't the current state of the code seem to NOT work in case of transitive nodes? That is, this is an undirected graph. So, the below should work.
graph = NetworkX::Graph.new
graph.add_edge('Chennai', 'Bangalore', distance: 350)
graph['Bangalore']
#=> { 'Chennai' => { 'distance' => 1 } }
|
Hey @ajeetdsouza! Really sorry for such a late review. As this PR's remote is not locatable, I'm closing this PR. If you'd like to work on the bug suggested above, please feel free to send a new PR. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the
Hashrepresentation of a Graph, very similar to the way it has been implemented in Python. Removed the type checking forArraysince most duck-typed programming languages discourage it.